Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use type keyword in enum schemas #1

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

eiriktsarpalis
Copy link
Owner

Following feedback from microsoft/semantic-kernel#5998 (comment) I'm changing the generated schema for enum types to always include the type keyword. Even though this is redundant for the case of enum schemas, this was reported to create problems when used with Gemini APIs.

cc @stephentoub @captainsafia @SergeyMenshykh @Krzysztof318

@eiriktsarpalis eiriktsarpalis merged commit 73471a5 into main Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant