Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize load in agent or in app #88

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

chenzhq
Copy link

@chenzhq chenzhq commented Sep 9, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

根据配置选择是在agent,还是app上初始化sequelize。

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #88 into master will decrease coverage by 1.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   85.71%   84.61%   -1.10%     
==========================================
  Files           4        4              
  Lines          63       65       +2     
==========================================
+ Hits           54       55       +1     
- Misses          9       10       +1     
Impacted Files Coverage Δ
config/config.default.js 100.00% <ø> (ø)
agent.js 66.66% <50.00%> (-33.34%) ⬇️
app.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc3a84...33b819b. Read the comment docs.

@@ -1,6 +1,8 @@
'use strict';

exports.sequelize = {
agent: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档里面加一下这两个参数

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -82,6 +82,8 @@ egg-sequelize has a default sequelize options below

```js
{
app: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解释一下这两个参数的含义

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方是告诉用户默认配置是什么,参数具体的解释放在这里吧:

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好,是我看错了

Copy link
Member

@dead-horse dead-horse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chenzhq
Copy link
Author

chenzhq commented Sep 11, 2020

这个可以 merge 发包吗

@JoweiBlog
Copy link

这个可以发个包么。🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants