Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改启动文件app.js、agent.js，将app.beforeStart替换为新版的启动自定义 #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

修改启动文件app.js、agent.js，将app.beforeStart替换为新版的启动自定义 #76

wants to merge 1 commit into from

Conversation

MrSmallLiu
Copy link

@MrSmallLiu MrSmallLiu commented Jul 9, 2019 •
edited

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse July 9, 2019 08:26
dead-horse
dead-horse reviewed Jul 19, 2019
View reviewed changes
app.js
}

async didLoad() {
// 请将你的插件项目中 app.beforeStart 中的代码置于此处。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉注释

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要把 loader 改造成 async function，否则你这里的变更有问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MrSmallLiu @dead-horse