Update OpenROAD #472
Merged
Update OpenROAD #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed OpenLane-specific patch for querying existence of antenna information
* `openroad-abc` -> `ef5389d`
* `ABC_USE_NAMESPACE` now set, result injected into header file
* `opensta` -> `ee8d3d0`
* `Odb.ReportDisconnectedPins` * Disconnected instances created during CTS, prefixed `clkload`, are now ignored.
|
Failed to create report: |
* `Odb.SetPowerConnections` * **Internal**: Restructure `Odb.SetPowerConnections` to provide better error messages and use dictionaries instead of oddball iterator-based filtering
- defutil: Copy power pins placement status when applying DEF template - In newer OpenROAD, any power BTerm that isn't "FIXED" will be removed completely if it's not connected when `pdngen` is called. In OpenFrame those get connected later (in TinyTapeout case by some custom script later and in the official example case using a macro). So to work around that, we changed the DEF template to make sure all power pins have the FIXED placement attribute and we make sure to copy it when applying the template. - Respect the net name for power pins when applying DEF templates - You can have different net name than the pin name, this is especially useful if you want several pins connected to the same net internally. Signed-off-by: Sylvain Munaut <[email protected]>
kareefardi
requested changes
Jun 4, 2024
|
I was too lazy to update the design's config so I decided to update OpenROAD instead |
|
i think this is one of those nondeterministic bugs bec the hold violation isn't there on macOS so that's fun |
kareefardi
approved these changes
Jun 6, 2024
…nds; matching how OpenROAD does it where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Odb.ReportDisconnectedPinsclkload, are now ignored.Odb.SetPowerConnectionspower_utils.pyto provide better error messages and use dictionaries instead of oddball iterator-based filteringTool Updates
openroad->b16bda7openroad-abc->ef5389dABC_USE_NAMESPACEnow set, value also injected into header filesopensta->e01d3f1Resolves #405
Resolves #440
Depends on efabless/openlane2-step-unit-tests#32
Depends on efabless/openlane2-ci-designs#30