Bug #218, respond with 4xx HTTP error codes, not 500

[nfreear]

Hi @eduardoboucas,

I've implemented a fix/enhancement for the #218 issue.

You'll see that it uses several sources to try to determine the HTTP status code — payload.rawError.code, then payload.rawError._smErrorCode.

The possible HTTP status codes are:

• 404 — REST purists may not agree with how I propose using this for "missing" config-type errors (some/all of these could be changed to 400 I suppose);
• 403 — one of the GitHub responses I think (Investigate alternative commenting ...? Staticman nfreear/nfreear-blog#32 (comment));
• 400 — most of the "invalid" request/ config-type responses;
• (500 — fallback, unknown error)
• 200 — success;

I hope this helps.

Best wishes,

Nick

[nfreear]

Hi @eduardoboucas,

The Travis-CI build fails because of a pre-existing standard style error.

If you ignore that, the unit tests etc. pass fine!

I hope that helps,

Nick

---

(Travis-CI: .. 407144707)

[eduardoboucas]

I must say I'm not sure I like the idea of using 404 for missing config properties. As you pointed out, I think a 400 would be more appropriate.

Other than that, it looks great. Thanks for this!