Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support charset #50

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Support charset #50

merged 3 commits into from
Dec 2, 2023

Conversation

ffes
Copy link
Member

@ffes ffes commented Nov 6, 2023

This adds support for the charset property. It converts the current document to the right charset before saving it.

Fixes #41

@ffes
Copy link
Member Author

ffes commented Nov 6, 2023

The failure of the CI seems to be the same issue as #31

@xuhdev
Copy link
Member

xuhdev commented Nov 9, 2023

I see the error message:

The server did not return the file size. The URL might point to dynamic content. The Content-Length header is not available in the server's HTTP reply.

Maybe the -Dynamic flag should be turned on? https://learn.microsoft.com/en-us/powershell/module/bitstransfer/start-bitstransfer?view=windowsserver2022-ps

@ffes
Copy link
Member Author

ffes commented Nov 21, 2023

Maybe the -Dynamic flag should be turned on?

That helped for GitHub Actions, thanks for the tip!

But for appveyor it doesn't work. It's PowerShell doesn't seem to recognise the -Dynamic flag

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should eventually drop appveyor for this repo. Let's merge this first.

@xuhdev xuhdev merged commit ad41f34 into editorconfig:master Dec 2, 2023
6 of 7 checks passed
@ffes ffes deleted the 41-support-charset branch December 4, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character Encoding not set as specified
2 participants