Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include test on macos-11 below 28.x #335

Merged
merged 4 commits into from
May 14, 2024

Conversation

sebastiaanspeck
Copy link
Contributor

Also change versions to unquoted, rename emacs_version to emacs-version and exclude windows-latest, snapshot in a nicer way

Also change versions to unquoted, rename `emacs_version` to `emacs-version` and exclude windows-latest, snapshot in a nicer way
@10sr
Copy link
Member

10sr commented May 14, 2024

Thanks for your PR!

I think unquoting versions is not so good, because in yaml values like 26.3 are treated as float, but actually versions are not float. Quoting versions prevents unexpected conversion of version strings...

@10sr 10sr merged commit b120ccd into editorconfig:master May 14, 2024
14 checks passed
@10sr
Copy link
Member

10sr commented May 14, 2024

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants