Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test keys set to empty strings #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jan 28, 2024

parser/CMakeLists.txt Outdated Show resolved Hide resolved
@cxw42
Copy link
Member

cxw42 commented Feb 11, 2024

Would it also be worth adding a testcase to parser/whitespace.in like

key= value with whitespace inside  $

($ = end of line)? That way we would expressly show the behaviour of preserving whitespace inside values. Currently we test that implicitly in comments.in, test semicolon_or_hash_in_property, but we don't have a test in the whitespace group for it.

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 12, 2024

Would it also be worth adding a testcase to parser/whitespace.in like

key= value with whitespace inside  $

($ = end of line)? That way we would expressly show the behaviour of preserving whitespace inside values. Currently we test that implicitly in comments.in, test semicolon_or_hash_in_property, but we don't have a test in the whitespace group for it.

Done in 9877f04

Could you please review again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants