New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA.GetAllRandom() performance improvements #3

Open

pymq wants to merge 1 commit into eddycjy:master from pymq:getallrandom_perfomance

pymq commented Dec 2, 2019

Thanks for this library!

I noticed two drawbacks and prepared a fix, please consider this for merging.

remove unnecessary slice allocations on each UA.GetAllRandom() call (about 3000 length slice on average);
add RWMutex to prevent data races;


remove unnecessary slice allocations on each UA.GetAllRandom() call (…

df27d89

…about 3000 length slice);

add RWMutex to prevent data races

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment