[wip][rfc] shell version(posix compatible) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on linux this weekend, that's the reason I echoed most final commands 🐹 sorry about that, If any good fellow want to test it, just remove echo and outer " |
|
most commands are done There some refactors lefts to do(most extract code duplication) and apply some options. |
|
What is the purpose of this PR? A complete reimplementation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a working in progress implementation.
goals:
that said, I'm opening this PR as a request for comments.
I will work in the Easter holiday in it and I expect to have a almost 100% compatible version next weekend.
@mperham: what do you think?
anyway, Thanks a lot for lunchy, it's a time saver!