Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): Add notification functionality #242

Open
wants to merge 3 commits into
base: v0.10.0
Choose a base branch
from

Conversation

edcarroll
Copy link
Owner

PR is WIP

This PR adds toast style notifications to the message components, as outlined in #103.

Will update this comment with more info when I have more time.

@edcarroll edcarroll changed the base branch from master to v0.10.0 August 11, 2017 16:08
@edcarroll
Copy link
Owner Author

@mcosta74 remade the PR manually so the diff is no longer stupid.

@edcarroll edcarroll modified the milestone: 0.10.0 Aug 11, 2017
@harogaston
Copy link
Contributor

What is the status on this? @edcarroll do you need extra hands?

@edcarroll
Copy link
Owner Author

@harogaston component is fully implemented, just want some feedback on the interface and how it works 😄 Check out the test component which has an active demo

@jmls
Copy link

jmls commented Aug 20, 2017

as per gitter

  • can a notification have colors - like the existing message container
  • can a notification have logos / images etc like the message container
  • can a notification be placed in the middle of the screen
  • can the progress bar go from left to right
  • can a notification use an ng-template for the message ?

for (1) and (2) I basically think if you could make a notification have the same ui as a message that would be great , as it would handle the colors, icons etc

@jmls
Copy link

jmls commented Apr 4, 2018

is it likely that this pr will make it into the main codebase ? Been waiting on it for some time now ;)

benjaminforras added a commit to benjaminforras/ngx-fomantic-ui that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants