Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of string expressions instead of lambdas when definition new format models. #1427

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

sbenthall
Copy link
Contributor

This PR allows the user to define 'new format models' with string mathematical expressions instead of lambdas.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall
Copy link
Contributor Author

This builds of #1417, which should be merged first

@mnwhite
Copy link
Contributor

mnwhite commented May 31, 2024

@sbenthall Very minor file conflicts now that #1417 has been merged: changed import statements, changes to example model that show the "non-lambda" version, new test added (why does that register as a "conflict"?), one changelog line, etc. You can probably better select the right version than I can.

@sbenthall
Copy link
Contributor Author

Got it, thanks @mnwhite
I'll fix the conflicts and polish the PR a little more and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants