Fixed non-idempotent test DeploymentTest#testDeployClass
#5190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The test
io.vertx.core.DeploymentTest.testDeployClass
is not idempotent and fails in the second run in the same JVM, because it pollutes state shared among tests. Specifically, it deploys a vertical but did not clean upReferenceSavingMyVerticle.myVerticles
after the deployment, hence the assertionassertEquals(deploymentId, myVerticle.deploymentID);
can fail whenmyVerticles
still contains verticals from the previous run. It shall be good to clean this state pollution so that other tests do not fail in the future due to the shared state polluted by this test.##Stacktrace of failure in the second run:
Proposed Fix
Clear
ReferenceSavingMyVerticle.myVerticles
before starting the individual tests.Conformance:
ECA Submitted