Remove un-necessary Http1xServerConnection internal state synchronised access

[vietj]

The Http1xServerConnection synchronize itself to guard the internal state of the request/response in progress.

Such synchronization used to be useful before Vert.x 4 and the clear dispatch between connection/request code. Currently read and writes are confined in the event-loop thread and removing this synchronization has no effect on the read/writes of this state.

[franz1981]

FYI:
https://github.com/quarkusio/quarkus/blob/main/independent-projects/resteasy-reactive/server/vertx/src/main/java/org/jboss/resteasy/reactive/server/vertx/ResteasyReactiveOutputStream.java#L53

and check Http1xServerRequest as well, which is still synchronizing over conn -> the connection

[vietj]

I think it should be fine for this case as we update the state of the request/response in progress and this sync and the request/close status which are not related to back-pressure/drain.

As said in the PR, the state we update in the synchronized block is accessed exclusively from the event-loop thread which is the reason we remove the synchronization. In addition none of these blocks calls another method.

Therefore it seems safe to me, WDYT ?

FYI: https://github.com/quarkusio/quarkus/blob/main/independent-projects/resteasy-reactive/server/vertx/src/main/java/org/jboss/resteasy/reactive/server/vertx/ResteasyReactiveOutputStream.java#L53

and check Http1xServerRequest as well, which is still synchronizing over conn -> the connection

[franz1981]

@vietj

the best way would be to try running some of the tests on Quarkus which relies on it, by using a vertx which version relax these properties (ie this PR) @geoand @cescoffier how it looks?

while re

and check Http1xServerRequest as well, which is still synchronizing over conn -> the connection

we have many other parts where we synchronize over connection within vertx, if we plan to remove this, I would go for the others as well

[vietj]

which others do you mean ?

in this PR I only meant to remove synchronised usage of state mutation that is confined to the event-loop thread which is a trivial decision

[franz1981]

which others do you mean ?

Http1xServerRequest, for example

[franz1981]

LGTM thanks!