-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ResourceUtilTest: replace AssertJ's deprecated method asList() #3073
fix ResourceUtilTest: replace AssertJ's deprecated method asList() #3073
Conversation
…issue eclipse-jkube#3057 Signed-off-by: arman-yekkehkhani <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #3073 (2024-05-22T06:18:20Z) ⚙️ JKube E2E Tests (9186153108)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3073 +/- ##
=============================================
+ Coverage 59.36% 71.00% +11.63%
- Complexity 4586 5069 +483
=============================================
Files 500 488 -12
Lines 21211 19445 -1766
Branches 2830 2502 -328
=============================================
+ Hits 12591 13806 +1215
+ Misses 7370 4421 -2949
+ Partials 1250 1218 -32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the imports problem, everything else looks fine.
Please, proceed with the requested changes and we can merge, thanks!
import io.fabric8.kubernetes.api.model.Service; | ||
import io.fabric8.kubernetes.api.model.ServiceAccount; | ||
import io.fabric8.kubernetes.api.model.ServicePortBuilder; | ||
import io.fabric8.kubernetes.api.model.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't use wildcard imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out. I fixed it.
Signed-off-by: arman-yekkehkhani <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Replace AssertJ's deprecated
asList()
DSL method withasInstanceOf(InstanceOfAssertFactories.list(type.class))
in classResourceUtilTest
.Fixes #3057
Type of change
test, version modification, documentation, etc.)
Checklist