-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenShift route generator: prefer port name over port number for targetPort when it's possible #2857
base: master
Are you sure you want to change the base?
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2857 (2024-06-13T14:31:15Z) ⚙️ JKube E2E Tests (9501023685)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
=============================================
+ Coverage 59.36% 70.59% +11.23%
- Complexity 4586 5015 +429
=============================================
Files 500 486 -14
Lines 21211 19473 -1738
Branches 2830 2508 -322
=============================================
+ Hits 12591 13747 +1156
+ Misses 7370 4500 -2870
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java
Outdated
Show resolved
Hide resolved
...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java
Outdated
Show resolved
Hide resolved
...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java
Outdated
Show resolved
Hide resolved
47167d1
to
936ec67
Compare
...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java
Outdated
Show resolved
Hide resolved
...richer/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricher.java
Show resolved
Hide resolved
...er/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java
Outdated
Show resolved
Hide resolved
...er/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java
Outdated
Show resolved
Hide resolved
@luigidemasi :Thanks, looks good to me with minor nitpicks. |
…etPort when it's possible
Quality Gate passedIssues Measures |
No description provided.