Prevent RdfNamespace::splitUri() from generating prefix:#fragment qnames
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a qname in the form `prefix:#fragment`, which is not valid; this fix prevents that
|
i'm keeping this as a draft for now because i'm not convinced it's not valid: throwing test cases at Protégé isn't returning the errors i was expecting, so i'm going to retrace my steps and work out what precisely was the issue with the Turtle that was being generated |
|
Two notes:
|
|
@zozlak thanks for the info. you're obviously more than welcome to apply these commits to your fork if you wish. |
|
The maintained fork is by @k00ni . |
k00ni
added a commit
to sweetrdf/easyrdf
that referenced
this pull request
Aug 28, 2023
Author: @nevali Title: Prevent RdfNamespace::splitUri() from generating prefix:#fragment qnames Quote from original PR: > it's possible to coax EasyRdf\RdfNamespace::splitUri() into generating a qname in the form prefix:#fragment, which is not valid, for example by defining a namespace as https://www.example.com/foo/ and then referring to https://www.example.com/foo/#bar; this fix prevents that
k00ni
added a commit
to sweetrdf/easyrdf
that referenced
this pull request
Aug 29, 2023
Author: @nevali Title: Prevent RdfNamespace::splitUri() from generating prefix:#fragment qnames Quote from original PR: > it's possible to coax EasyRdf\RdfNamespace::splitUri() into generating a qname in the form prefix:#fragment, which is not valid, for example by defining a namespace as https://www.example.com/foo/ and then referring to https://www.example.com/foo/#bar; this fix prevents that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's possible to coax EasyRdf\RdfNamespace::splitUri() into generating a qname in the form
prefix:#fragment, which is not valid, for example by defining a namespace ashttps://www.example.com/foo/and then referring tohttps://www.example.com/foo/#bar; this fix prevents that