make emojis.json a ts file so no bad path in type defs #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ealush Can we merge this? I am having same issues, my build pipeline keeps failing. Run set -o pipefail the json file doesn't exist under dist directory, its only present under src hence the problem. this will prevent me from using the library and our release date is close. Please help me resolve this issue. Note, I can't add skipLibcheck in this project. |
ealush
force-pushed
the
master
branch
2 times, most recently
from
8673ce9
to
d8ad1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writes 'emojis.ts' instead of 'emojis.json' so that there is no bad path to './emojis.json' in dist/ ( the json is only in src/ )
closes [https://github.com//issues/294] i think - i was seeing the same error in a library project with typescript ( i have a typescript build as a git hook - the rollup build worked fine, guess cos rollup doesnt need to resolve emojis.json in the ts defs )