Fix docker builds

[duncdrum]

remove superfluous layers see experimental builds if it works

close #4894

[duncdrum]

build succeeds, container tests do too, push fails because this is from a PR from a fork, but attempt is visible.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[dizzzz]

@duncdrum @reinhapa ?

[adamretter]

If I am not mistaken, whilst this is interesting, it removes support for Apache FOP, and therefore we may not want to merge this. Is that correct?

[duncdrum]

it removes support for Apache FOP

it does not. The layers are superfluous, not the deps

[adamretter]

it does not. The layers are superfluous, not the deps

@duncdrum Sorry can you explain that please? In your PR here, it appears that you have commented out the dependencies that are required for Apache FOP - https://github.com/eXist-db/exist/pull/4895/files#diff-e06009c91b03b0212493cef67386d831bde8dc3729db1c33707e1f24458c1ad2R31

Am I mistaken... or are those lines not now commented out?

[duncdrum]

@adamretter the dependencies are part of the java base image, no need to create new layers via COPY

[adamretter]

@duncdrum So I think you are saying that the dependencies required for Apache FOP are available in gcr.io/distroless/java17:latest, and so we no longer need to copy them in from debian:bullseye-slim. Is that correct?

[duncdrum]

@adamretter yes

[adamretter]

@duncdrum Okay great. Thank you :-)

[adamretter]

@duncdrum I think you missed a file. The same changes will need to be made to Dockerfile-DEBUG too. Additionally can we just remove all the commented out stuff. There doesn't seem to be any value in leaving it there, no?

[duncdrum]

@adamretter i would wait to check the fallout from the default apps. We know that there are problems on develop, but as of now all our tests show green. Once we re back on solid footing we can delete things , clean up the docker Pom, and inline the experimental images

[reinhapa]

@duncdrum did I merge the quickly?

[duncdrum]

@reinhapa no the deploy for :latest is running again, and we have proper CI checks moving forward. That constituted the hotfix. Once this had time to percolate, i ll do a cleanup PR, with outstanding cosmetic changes.