[bugfix] fn:matches error codes #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the error code raised by the Saxon regular expression implementation. This will now correctly raise FORX0002 when the pattern is invalid.
joewiz
reviewed
Apr 26, 2023
exist-core/src/main/java/org/exist/xquery/functions/fn/FunAnalyzeString.java
Outdated
Show resolved
Hide resolved
|
XQTS results are in:
Astounding what one can achieve with the smallest of changes. |
|
I would really love to see the percentage of passing tests in the XQTS results.
|
- use enhanced switch for readability - add general error code to default case
line-o
force-pushed
the
fix/matches-error-code
branch
from
5f97429
to
9d80c4d
Compare
|
now an additional two XQTS tests pass ... 👀 |
duncdrum
reviewed
Apr 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dizzzz
approved these changes
May 8, 2023
|
With two approvals from core devs, this can be merged. Thanks @line-o and thanks @adamretter and @dizzzz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Read the error code raised by the Saxon regular expression implementation.
This will now correctly raise FORX0002 when the pattern is invalid.
Reference:
https://www.w3.org/TR/xpath-functions-31/#func-matches
Type of tests:
added XQSuite tests