Fix missing fn:transform global parameters #4883

alanpaxton · 2023-04-25T16:04:55Z

Description:

Transformation fails to load global parameters from the stylesheet when it is loaded from eXist-db (rather than in memory).

Stylesheet document fetching into sources is not recognising as documents the documents it received from the DB (as opposed to ones which are constructed in memory). All our testing has been done with temporary in memory documents and we missed the case of a transformation source coming from the persistent db.

To fix this, we just have to recognise org.exist.dom.persistent.DocumentImpl as well as org.exist.dom.memtree.DocumentImpl as a valid document source; similarly, the case where a document can be a NodeProxy wasn’t recognised, we just need to fetch the node from the proxy when we recognise it as such, and proceed with using a source wrapping the resulting node as the stylesheet source.

Reference:

Closes #4609

Type of tests:

eXide files detailed in the bug report now produce the correct transformation, rather than an error
Added an XQSuite unit test transformation loading stylesheet from a resource: and input document from database added; confirmed this Unit Test failed before the changes and now passed.

Problem manifests when loading the stylesheet from eXist-db. Stylesheet document fetching into sources is not recognising as documents the documents it received from the DB (as opposed to ones which are constructed in memory). All our testing has been done with temporary in memory documents and we missed the case of transform source in eXist-db. To fix it, we just have to recognise org.exist.dom.persistent.DocumentImpl as well as org.exist.dom.memtree.DocumentImpl as a valid document source; similarly, the case where a document can be a NodeProxy wasn’t recognised, we just need to fetch the node from the proxy when we recognise it as such, and proceed with using a source wrapping the resulting node as the stylesheet source. This appears to make the