Prevent unnecessary optimisation of already optimised Range Index expressions #4882
Conversation
adamretter
force-pushed
the
fix/3624
branch
2 times, most recently
from
2d1f6c4
to
77231a9
Compare
adamretter
changed the title
adamretter
added
bug
This reverts commit 35a76f2.
…s.range.RangeQueryRewriter.rewriteLocationStep" This reverts commit 56e190a.
… is already optimized. Closes eXist-db#3624
|
SonarCloud Quality Gate failed.
|
| if (expression instanceof final InternalFunctionCall fcall) { | ||
| expression = fcall.getFunction(); | ||
| } | ||
| this.fallback = expression; |
There was a problem hiding this comment.
@marmoure you may fix this Codacy issue by using a if /else block:
if (expression instanceof final InternalFunctionCall fcall) {
this.fallback = fcall.getFunction();
} else {
this.fallback = expression;
}
There was a problem hiding this comment.
Whilst the end result is the same. I am not sure this is the same intention, it was meant to be clear that we are replacing the expression. @reinhapa How strongly do you feel about this?
There was a problem hiding this comment.
Well I would like to somehow bring the total qualtiy issues down when they pop up as I think we should try to avoid new issues if possible...
| if (expression instanceof final InternalFunctionCall fcall) { | ||
| expression = fcall.getFunction(); | ||
| } | ||
| this.fallback = expression; |
There was a problem hiding this comment.
Whilst the end result is the same. I am not sure this is the same intention, it was meant to be clear that we are replacing the expression. @reinhapa How strongly do you feel about this?
Closes #3624
This PR prevents optimizing an already optimized expression.
It reverts the previous fix in PR #3625 as that PR causes eXist-db to do more work that necessary. This PR takes a simpler approach that requires less processing and less creation of objects by eXist-db (and therefore is faster and more memory efficient).
This open source contribution to the exist project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.