Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mvnd in GitHub Actions #4859

Merged
merged 4 commits into from
May 31, 2023

Conversation

adamretter
Copy link
Member

@adamretter adamretter commented Apr 9, 2023

Builds atop #4917 to switch CI from using mvn to mvnd (i.e. Maven Daemon)

@adamretter adamretter added the ci issues related to continuous integration label Apr 9, 2023
@adamretter adamretter requested a review from reinhapa April 9, 2023 22:34
@adamretter adamretter force-pushed the improve/githubactions branch 16 times, most recently from 1f420d1 to 1404591 Compare April 10, 2023 11:04
@adamretter
Copy link
Member Author

adamretter commented Apr 10, 2023

I am aware that connecting to the Maven Daemon in Windows and macOS runners seems to intermittently fail even though I have provided a generous timeout of 90 seconds. I have made enquiries about that here - apache/maven-mvnd#772 (comment)

Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dizzzz
Copy link
Member

dizzzz commented Apr 20, 2023

OK to pull?

@duncdrum
Copy link
Contributor

duncdrum commented May 1, 2023

@dizzzz as long as the problems with mavend on win and macOS persist, I d say no. Otherwise we give up testing on the list of supported platforms.

The config changes do not depend on mavend. We either wait for things to get sorted out upstream with mavend or create a new PR without mavend

@reinhapa
Copy link
Member

reinhapa commented May 5, 2023

@dizzzz as long as the problems with mavend on win and macOS persist, I d say no. Otherwise we give up testing on the list of supported platforms.

The config changes do not depend on mavend. We either wait for things to get sorted out upstream with mavend or create a new PR without mavend

@duncdrum as far as I can see do the actual test pass on Windows, "only" the coverage part fails with a timeout... I'm in the process to check that build on my Windows instance at the moment...

@duncdrum
Copy link
Contributor

duncdrum commented May 6, 2023

@reinhapa unfortunately the mavend time-out linked above occurs on the start of ci run, so the test won’t run.

If that issue has been fixed good to merge, but otherwise we should still hold, otherwise we risk PRs with stuck runs on both win and macOS

@adamretter adamretter changed the title Further improvements to GitHub Actions config Use mvnd in GitHub Actions May 11, 2023
@adamretter
Copy link
Member Author

I separated the non-mvnd related changes out into a new PR (which should be merged first) - #4917

@adamretter adamretter force-pushed the improve/githubactions branch 2 times, most recently from db45b4a to 7b68456 Compare May 12, 2023 07:48
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dizzzz
Copy link
Member

dizzzz commented May 30, 2023

I missed the latest changes, my apologies. It looks OK to me right now!

@dizzzz dizzzz merged commit 9ec8832 into eXist-db:develop May 31, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants