-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Allow Saxon licensed editions (EE and PE) #4854
Merged
adamretter
merged 14 commits into
eXist-db:develop
from
evolvedbinary:feature/eb-4813-allow-saxon-licensed-editions
May 10, 2023
Merged
[feature] Allow Saxon licensed editions (EE and PE) #4854
adamretter
merged 14 commits into
eXist-db:develop
from
evolvedbinary:feature/eb-4813-allow-saxon-licensed-editions
May 10, 2023
Commits on Apr 24, 2023
-
[feat] Fetch/read saxon conf via broker pool
Set up to configure Saxon with a license for PE/EE if we find such a license, assume at that point that PE/EE has been manually installed. WIP - not fully tested, UT or manually, and we need manual testing after installing EE to confirm that we can get the features we want. [fix] Remove licence file stuff, comment code There is no point in us pushing a licence file into Saxon from a different place, because as soon as we ask Saxon to load a configuration it looks for a licence file. We will just ask to dump a licence file where Saxon expects it by default. Comment the methods in the configuration holder.
Configuration menu - View commit details
-
Copy full SHA for 7260c03 - Browse repository at this point
Copy the full SHA 7260c03View commit details -
[fix] Link to and polish the placeholder saxon config.
The saxon-config.xml file we supply does nothing, it just acts as a placeholder for a fully-realised saxon-config.xml when a licensed Saxon edition is installed.
Configuration menu - View commit details
-
Copy full SHA for cb05194 - Browse repository at this point
Copy the full SHA cb05194View commit details -
[test] Document and validate HE to EE upgrade procedure.
Instructions in markdown for how to achieve this.
Configuration menu - View commit details
-
Copy full SHA for d1ea717 - Browse repository at this point
Copy the full SHA d1ea717View commit details -
[refactor] Rename, add licence header, remove license testing
Saxon config tests that we find the saxon config file; the part about looking for a license file is not implemented.
Configuration menu - View commit details
-
Copy full SHA for 77b0c1a - Browse repository at this point
Copy the full SHA 77b0c1aView commit details -
[refactor] Review feedback (human and automatic)
De-genericize static names Don’t capitalize static method Remove unused imports Unpick method for complexity metric Re-order some qualifiers Make markdown conform to checker rules
Configuration menu - View commit details
-
Copy full SHA for 866b63d - Browse repository at this point
Copy the full SHA 866b63dView commit details -
[refactor] how broker pool holds saxon config
We don’t need a map of broker pool to saxon config, I’m not sure why we made it like that in the first place. Broker pool just needs a (lazy) reference to its own saxon configuration (wrapper).
Configuration menu - View commit details
-
Copy full SHA for c3c82de - Browse repository at this point
Copy the full SHA c3c82deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4170f09 - Browse repository at this point
Copy the full SHA 4170f09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9772b00 - Browse repository at this point
Copy the full SHA 9772b00View commit details
Commits on Apr 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd89760 - Browse repository at this point
Copy the full SHA fd89760View commit details
Commits on Apr 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3a4b2fe - Browse repository at this point
Copy the full SHA 3a4b2feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f9ec3 - Browse repository at this point
Copy the full SHA 09f9ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22524de - Browse repository at this point
Copy the full SHA 22524deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28e1d47 - Browse repository at this point
Copy the full SHA 28e1d47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8da4669 - Browse repository at this point
Copy the full SHA 8da4669View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.