Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x.x] tails of subsequences off by one #4851

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

line-o
Copy link
Member

@line-o line-o commented Apr 4, 2023

Description:

Backport of #4850

Reference:

#4830

Type of tests:

XQSuite tests

@line-o line-o requested a review from a team April 4, 2023 11:06
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is stuck at dependency checks

@adamretter adamretter changed the title Backport: tails of subsequences off by one [6.x.x] tails of subsequences off by one Apr 7, 2023
@adamretter adamretter self-requested a review April 7, 2023 10:44
Copy link
Member

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same small issues as discussed here - #4850 (review)

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. Now LGTM :-)

@adamretter
Copy link
Member

@line-o Just needs 1 more approval from a core dev and then we can merge - @reinhapa as you reviewed and approved the non-backport would you be able to approve this one

@line-o
Copy link
Member Author

line-o commented Apr 19, 2023

I want to point out that @duncdrum is a member of the core team which makes him a core-dev to me.

@adamretter
Copy link
Member

I want to point out that @duncdrum is a member of the core team which makes him a core-dev to me.

I believe you are mistaken:

The list of core developers for the eXist-db/exist repository was agreed at a Community Call that you were present at. It was documented in the Community document entitled Community Code Review and Merge Policy for the exist-db/exist Git Repository. If I recall correctly you agreed to this revised version of the document. The list is under the heading “Core Team” members of the exist-db/exist repository in that co-authored document, see here - https://docs.google.com/document/d/1O724HZ2s3ffhclMATVpVTIskdCNhazA11A7GqxlGe24

I am afraid that @duncdrum does not appear in that list.

@adamretter adamretter merged commit 26d643e into eXist-db:develop-6.x.x Apr 19, 2023
10 of 16 checks passed
@line-o line-o deleted the backport/4830 branch July 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants