Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.5 segfault #803

Open
wants to merge 26 commits into
base: v5.5
Choose a base branch
from
Open

v5.5 segfault #803

wants to merge 26 commits into from

Conversation

fredbcode
Copy link
Contributor

@fredbcode fredbcode commented Mar 26, 2024

Hi @philipianpearce @sunweaver

The latest changes breaks e2 (the load average is huge and e2 segfault) and I'm trying to understand why
At first #797 hard code limits for 32 and 64,bits, if I understand well, and the limit is very low for professional usage

So I added an optional compilation "--with-httpworkers=16384" to hardcode limit if necessary, uninformatively e2 still slow and segfault randomly, I guess I'm doing something wrong

Right now , I'm testing previous version pcre version, but I guess this is unrelated

Of course, this pull request is just for discussion, the issue still here

@fredbcode
Copy link
Contributor Author

I confirm not related with pcre changes

@philipianpearce
Copy link
Contributor

Fred, Note tests are failing on debianarm - How much memory is gitlab configured for this test?

If not enough for number of httpworkers - may explain slowness/no response/segfault.

Are you getting issues on a production set-up as well or just on gitlab?

@fredbcode
Copy link
Contributor Author

fredbcode commented Mar 26, 2024 via email

@fredbcode
Copy link
Contributor Author

fredbcode commented Mar 26, 2024 via email

@fredbcode
Copy link
Contributor Author

The ci part is fixed, working now with https://github.com/e2guardian/e2guardian/pull/798/files

@fredbcode
Copy link
Contributor Author

I created a branch https://github.com/e2guardian/e2guardian/tree/ftempfix for my team, this branch works well at commit f6957c7

@philipianpearce
Copy link
Contributor

Fred, I have reverted the pcre2 and httpworkers commit, so v5.5 should now be effectively back to commit f6957c7.

I have created a testpcre2 branch so that this can be tested further if needed. But as v5.5 should be stable release, will look at these updates in v5.6.dev to see the best way to implement them in more detail.

Thanks for all your investigation.
Philip

@fredbcode
Copy link
Contributor Author

Perfect, I will fix CI

@fredbcode
Copy link
Contributor Author

CI fixed https://gitlab.com/fredbcode/e2guardian/-/pipelines

Did you find an explanation about this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants