Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase limit for file upload #155

Merged
merged 6 commits into from May 11, 2024
Merged

Increase limit for file upload #155

merged 6 commits into from May 11, 2024

Conversation

ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented May 6, 2024 •
edited

This PR increases the limit for file upload.

There are several problems that are not resolved by just increasing the allowed body size in proxies:

  • Increased body size limit
  • Turn off proxy buffering
  • Remove envd upload handler in memory limit
  • Notify about not enough space on disk
  • Change multipart parsing so it does not use the filesystem for caching and then for writing
  • Test in sandbox
  • Add GOMEMLIMIT
  • Test correct filepaths

@ValentaTomas ValentaTomas marked this pull request as ready for review May 9, 2024 23:45
@ValentaTomas ValentaTomas added the improvement Improvement for current functionality label May 9, 2024
@ValentaTomas ValentaTomas requested a review from jakubno May 9, 2024 23:54
@ValentaTomas ValentaTomas merged commit 39ede14 into main May 11, 2024
@ValentaTomas ValentaTomas deleted the upload branch May 11, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubno jakubno jakubno approved these changes

Assignees
No one assigned
Labels
improvement Improvement for current functionality
Projects
E2B Roadmap
Status: 🚢 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ValentaTomas @jakubno