New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop setting defaults on validators #988
base: master
Are you sure you want to change the base?
Conversation
Default will be declared on validators but applied only on get method Fix #981
✅ Deploy Preview for dynaconf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Test Results (Python 3.11)468 tests - 1 464 ✔️ - 5 40s ⏱️ -1s For more details on these failures, see this check. Results for commit 9143590. ± Comparison against base commit 97366d6. This pull request removes 5 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results (Python 3.10)468 tests - 1 464 ✔️ - 3 41s ⏱️ -1s For more details on these failures, see this check. Results for commit 9143590. ± Comparison against base commit 97366d6. This pull request removes 5 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results (Python 3.8)468 tests - 1 464 ✔️ - 5 38s ⏱️ -1s For more details on these failures, see this check. Results for commit 9143590. ± Comparison against base commit 97366d6. This pull request removes 5 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
copilot:poem |
@rochacbruno The breaking change in #980 (such as turning off toml parsing on setdefault, or other) will be somehow implemented here? So we can add a warning on the |
inspect_settings: * change inspect_settings report-output format names and structure * implement 'history_limit' on 'utils.inspect:inspect_settings' * rename key_dotted_path to key * rename history_sort to new_first * enforce usage of kwargs, except for "settings", "key" and "env" * merge "output_format" and "custom" into "dumper" * add "report_builder" to allow output customization * add explicit 'print_report' param cli: * implement cli --limit|-n * update cli to match 'inspect_settings' changes non-breaking-change * minor "utils.inspect" internal renames * re-write docstrings in sphinx-style (:param foo) * expose 'get_history' * refactor 'test_cli.py': use more robust test isolation strategy * add data return to 'inspect_settings' for cleaner testing
Shortlog of commits since last release: Bruno Rocha (6): Release version 3.2.1 Hooking: Add support for changing the wrapped class (#975) Hotfix bypass evaluation #984 (#985) Fix #976 from envvars parse True/False as booleans (#983) Fix #982 glob on settings_files (#987) docker compose is available on CI no need to install Pedro Pessoa (1): Inspect Feature Review (#958)
Hi @rochacbruno Is there any rough estimate for this PR? |
Default will be declared on validators
but applied only on get method
Fix #981