Build translated docs to fix #797 #826

winmorre · 2022-10-30T22:29:18Z

To test this PR

run python ./scripts/docs.py build-all This will build the docs site

run python ./scripts/docs.py serve This will serve the doc site

netlify · 2022-10-30T22:29:24Z

✅ Deploy Preview for dynaconf ready!

Name	Link
🔨 Latest commit	`ac45613`
🔍 Latest deploy log	https://app.netlify.com/sites/dynaconf/deploys/6384a21a41cafb000748156c
😎 Deploy Preview	https://deploy-preview-826--dynaconf.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

winmorre · 2022-10-30T22:45:33Z

In release.sh file release.sh file line 102
I think there will be a need to update how the command is run. pointing to the right mkdocs.yaml file. Probably point to docs/en/mkdocs.yml file.

I think they will be a change to this command too https://github.com/dynaconf/dynaconf/blob/master/release.sh#L133
and this too https://github.com/dynaconf/dynaconf/blob/master/release.sh#L134

This too https://github.com/dynaconf/dynaconf/blob/master/netlify.toml#L5 will need to run the python ./scripts/docs.py build-all command

@rochacbruno Please check through these files and let me know the changes I'm proposing is correct

rochacbruno · 2022-11-02T10:55:45Z

Hi @winmorre the preview site is not loading, and I guess it is because it is missing the customizations on https://github.com/dynaconf/dynaconf/blob/master/netlify.toml

winmorre · 2022-11-03T09:19:11Z

Hi @winmorre the preview site is not loading, and I guess it is because it is missing the customizations on https://github.com/dynaconf/dynaconf/blob/master/netlify.toml

@rochacbruno Please how do I go about this?
looking the link sent but don't know what to do to fix this

rochacbruno · 2022-11-03T10:34:36Z

Hi @winmorre the preview site is not loading, and I guess it is because it is missing the customizations on https://github.com/dynaconf/dynaconf/blob/master/netlify.toml

@rochacbruno Please how do I go about this? looking the link sent but don't know what to do to fix this

Replace mkdocs build --clean with the call to the script you added python ./scripts/docs.py build-all

winmorre · 2022-11-04T18:58:19Z

@rochacbruno I have updated the PR

Fix a testing error on CI Co-authored-by: Vicente Marçal <[email protected]>

…morre/dynaconf into translated-docs/dynaconf#797

winmorre · 2022-11-27T10:57:38Z

@rochacbruno please I have fix the merge conflicts and I have updated the PR

rochacbruno · 2022-11-28T10:11:03Z

thanks @winmorre to figure out the build error.

rochacbruno · 2022-11-28T10:12:19Z

.github/workflows/main.yml

@@ -61,7 +61,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
- python-version: ["3.8", "3.10"]
+ python-version: ["3.8", "3.10", "3.11"]


Why Python "3.9" has been dropped ? it is on master https://github.com/dynaconf/dynaconf/blob/0439bf836f1a22e96e4c71d388c2e68fd9b70425/.github/workflows/main.yml#LL39-L39C55

rochacbruno · 2022-11-28T10:13:54Z

docs/en/docs/configuration.md

@@ -275,13 +275,13 @@ With `merge_enabled` the ending `settings.server` will be
 ```python
 {"port": 8888, "address": "server.com"}
 ```
-otherwise it will be only what is specified in the latest loaded file. read more about [merging strategies](/merging)
+otherwise it will be only what is specified in the latest loaded file. read more about [merging strategies](/docs/en/docs/merging.mdng.md)


why is it pointing to .mdng.md file?

rochacbruno · 2022-11-28T10:14:12Z

docs/en/docs/envvars.md

@@ -8,7 +8,7 @@ In addition to that Dynaconf offers some approaches you may want to **Optionally

 - Add a list of validators to `validators=[Validator()]` on your dynaconf settings instance and provide [defaults and constraints](/validation/).
 - Enable `load_dotenv` and provide a `.env.example` or `.env` file with the default variables.
- Write your variables in a [settings file](/settings_files) in the format of your choice.
+- Write your variables in a [settings file](/docs/en/docs/settings_files.mdes.md) in the format of your choice.


what does mdes.md stands for?

let me get it fixed

rochacbruno · 2022-11-28T10:14:49Z

docs/en/docs/release_notes.md

@@ -134,7 +134,7 @@ settings = Dynaconf(**options)

 and then in your program you do `from project.config import settings` instead of `from dynaconf import settings`.

-The `**options` are any of the [dynaconf config options](/configuration)
+The `**options` are any of the [dynaconf config options](/docs/en/docs/configuration.mdon.md)


hmmm
I actually didn't change things there
But let me fix those and update the PR

rochacbruno · 2022-11-28T10:16:02Z

Looks like this needs a rebase from master?

winmorre · 2022-11-28T10:18:51Z

Looks like this needs a rebase from master?

ok

…morre/dynaconf into translated-docs/dynaconf#797

winmorre · 2022-11-28T12:02:54Z

@rochacbruno I have updated the PR

Build translated docs

d6e1e59

winmorre added 2 commits October 30, 2022 22:30

updated contribute link

3c97946

fix requirement.txt file build error

5b0ba4f

deleted fr and es docs folder

0ca50e9

Build translated docs to fix dynaconf#797

36759f2

rochacbruno and others added 8 commits November 7, 2022 19:14

Add Python 3.11 to CI (dynaconf#830)

94b9b44

Fix a testing error on CI Co-authored-by: Vicente Marçal <[email protected]>

fix: envvars.md get HOME environment variable (dynaconf#831)

0439bf8

Build translated docs

e9cc00d

updated contribute link

369785a

fix requirement.txt file build error

38ab8d6

deleted fr and es docs folder

a888c00

Build translated docs to fix dynaconf#797

e5fdd3d

Merge branch 'translated-docs/dynaconf#797' of https://github.com/win…

3c75134

…morre/dynaconf into translated-docs/dynaconf#797

winmorre closed this Nov 27, 2022

winmorre reopened this Nov 27, 2022

winmorre added 3 commits November 27, 2022 10:47

Build translated docs

c3ceceb

deleted fr and es docs folder

4595727

Merge branch 'translated-docs/dynaconf#797' of https://github.com/win…

5422f1d

…morre/dynaconf into translated-docs/dynaconf#797

Fix build error with pre-commit flake8

a4f1a63

rochacbruno reviewed Nov 28, 2022

View reviewed changes

winmorre added 6 commits November 28, 2022 11:38

Fixed conflicts

18f1653

Fixed merge conflicts

b8b4d23

Build translated docs to fix dynaconf#797

dd01fd8

Fix build error with pre-commit flake8

1352820

Merge branch 'translated-docs/dynaconf#797' of https://github.com/win…

990e0cf

…morre/dynaconf into translated-docs/dynaconf#797

Updated the release_notes.md file

ac45613

pedro-psb mentioned this pull request Apr 24, 2023

[RFC] Versioned Docs #925

Closed

pedro-psb mentioned this pull request Feb 26, 2024

docs: Fix mkdocs warnings for cleaner build output #1061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build translated docs to fix #797 #826

Build translated docs to fix #797 #826

winmorre commented Oct 30, 2022

netlify bot commented Oct 30, 2022 •

edited

winmorre commented Oct 30, 2022

rochacbruno commented Nov 2, 2022

winmorre commented Nov 3, 2022

rochacbruno commented Nov 3, 2022

winmorre commented Nov 4, 2022

winmorre commented Nov 27, 2022

rochacbruno commented Nov 28, 2022

rochacbruno Nov 28, 2022

rochacbruno Nov 28, 2022

rochacbruno Nov 28, 2022

winmorre Nov 28, 2022

rochacbruno Nov 28, 2022

winmorre Nov 28, 2022

rochacbruno commented Nov 28, 2022

winmorre commented Nov 28, 2022

winmorre commented Nov 28, 2022

Build translated docs to fix #797 #826

Are you sure you want to change the base?

Build translated docs to fix #797 #826

Conversation

winmorre commented Oct 30, 2022

netlify bot commented Oct 30, 2022 • edited

✅ Deploy Preview for dynaconf ready!

winmorre commented Oct 30, 2022

rochacbruno commented Nov 2, 2022

winmorre commented Nov 3, 2022

rochacbruno commented Nov 3, 2022

winmorre commented Nov 4, 2022

winmorre commented Nov 27, 2022

rochacbruno commented Nov 28, 2022

rochacbruno Nov 28, 2022

Choose a reason for hiding this comment

rochacbruno Nov 28, 2022

Choose a reason for hiding this comment

rochacbruno Nov 28, 2022

Choose a reason for hiding this comment

winmorre Nov 28, 2022

Choose a reason for hiding this comment

rochacbruno Nov 28, 2022

Choose a reason for hiding this comment

winmorre Nov 28, 2022

Choose a reason for hiding this comment

rochacbruno commented Nov 28, 2022

winmorre commented Nov 28, 2022

winmorre commented Nov 28, 2022

netlify bot commented Oct 30, 2022 •

edited