Make Read and Write generics friendlier to dynamic dispatch #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By relaxing size constraint. Avoid double indirection. Instead of having to pass `&mut &mut dyn AsyncWrite`, we can pass `&mut dyn AsyncWrite`, for example. The use case for dynamic dispatch is object-safe traits. Static dispatch is unaffected.
r-ml
force-pushed
the
dynamic-dispatch-friendly
branch
from
a7c9ef6
to
e9804eb
Compare
|
@r-ml nice one! Thank you! |
durch
pushed a commit
that referenced
this pull request
Jun 14, 2024
By relaxing size constraint. Avoid double indirection. Instead of having to pass `&mut &mut dyn AsyncWrite`, we can pass `&mut dyn AsyncWrite`, for example. The use case for dynamic dispatch is object-safe traits. Static dispatch is unaffected.
durch
pushed a commit
that referenced
this pull request
Jun 14, 2024
By relaxing size constraint. Avoid double indirection. Instead of having to pass `&mut &mut dyn AsyncWrite`, we can pass `&mut dyn AsyncWrite`, for example. The use case for dynamic dispatch is object-safe traits. Static dispatch is unaffected.
durch
pushed a commit
that referenced
this pull request
Jun 14, 2024
By relaxing size constraint. Avoid double indirection. Instead of having to pass `&mut &mut dyn AsyncWrite`, we can pass `&mut dyn AsyncWrite`, for example. The use case for dynamic dispatch is object-safe traits. Static dispatch is unaffected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By relaxing size constraint.
Avoid double indirection. Instead of having to pass
&mut &mut dyn AsyncWrite, we can pass&mut dyn AsyncWrite, for example. The use case for dynamic dispatch is object-safe traits. Static dispatch is unaffected.tokioandstddo the same thing, for example tokio::io::copy and std::io::copy.Example of the problem and desired outcome.