-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use slices for multipart chunk data #351
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When uploading large amounts of data I would like to avoid as many copies as possible.
put_multipart_chunk
currently requires moving aVec<u8>
as the input chunk which may require copying the chunk if it must be used elsewhere. Also this is different fromput_object
which uses&[u8]
as the input.Describe the solution you'd like
I would like
put_multipart_chunk
to accept a&[u8]
slice as its input.Describe alternatives you've considered
Refactoring my application to copy data or perform the put as the last step could work but seems unnecessary.
Additional context
Both
put_multipart_chunk
andput_object
end up callingCommand::PutObject
with a slice and my cursory look at the source I didn't see any obvious reason moving was required for the putting chunks.If this is something desired I would be happy to put a PR together.
The text was updated successfully, but these errors were encountered: