Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put_multipart_chunk should NOT consume the chunk parameter #375

Closed
szguoxz opened this issue Jan 4, 2024 · 1 comment
Closed

put_multipart_chunk should NOT consume the chunk parameter #375

szguoxz opened this issue Jan 4, 2024 · 1 comment
Assignees
Milestone

Comments

@szguoxz
Copy link

szguoxz commented Jan 4, 2024

pub async fn put_multipart_chunk(
&self,
chunk: vec,
path: &str,
part_number: u32,
upload_id: &str,
content_type: &str,
) -> Result<Part, S3Error>

parameter chunk really should be of type &[u8] instead of a vec.
This makes a big difference as if my part is 100MB, you will require 100MB more memory. use &[u8] will allow me to reuse the read buffer.

@urkle
Copy link
Contributor

urkle commented Jan 4, 2024

Duplicate of #351

@durch durch self-assigned this Jun 17, 2024
@durch durch added this to the 0.35 milestone Jun 17, 2024
@durch durch closed this as completed in 6f339bb Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants