Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

WIP: Add load balancer to ASG #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Add load balancer to ASG #434

wants to merge 3 commits into from

Conversation

linc01n
Copy link

@linc01n linc01n commented Oct 9, 2018

No description provided.

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling d92a562 on linc01n:add-load-balancer-to-asg into 50e09f9 on dtan4:master.

dtan4
dtan4 suggested changes Apr 21, 2019
View reviewed changes
Copy link
Owner

@dtan4 dtan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 🙇

  • Could you add changes in tfstate? I think Terraform will show diff unless tfstate is updated.
  • Could you add a testcase about to generate the additional fields?

@linc01n
Copy link
Author

linc01n commented Apr 25, 2019

Sure. Let me update it in the weekend.

@linc01n linc01n changed the title Add load balancer to ASG WIP: Add load balancer to ASG Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dtan4 dtan4 dtan4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linc01n @coveralls @dtan4