Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed clang compiler error and warnings #132

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

hannorein
Copy link
Collaborator

This fixes #131 and a few other compiler warnings.

There was quite a bit of unused code in gr_full. I've commented it out - which doesn't change any result - but I'm not sure if gr_full works as expected.

@dtamayo
Copy link
Owner

dtamayo commented Jun 28, 2024

Thanks Hanno, will look at gr full when I get in

@dtamayo dtamayo merged commit 5a8389b into dtamayo:main Jun 28, 2024
6 checks passed
@dtamayo
Copy link
Owner

dtamayo commented Jun 28, 2024

Thanks again Hanno, sorry I was away yesterday. I'm not sure why I wasn't getting that compilation error on my computer or on the github CI.

I think gr_full is working as expected. Here is a run with two 1e-4 planets, plotting the relative error in the GR hamiltonian

image

I modified it to calculate barycentric coordinates as intended, and I pulled out all the constant terms from the iteration loop so the varying corrections are significantly smaller and converge faster.

I think now after the updates to the unit tests, the REBOUNDx tests triggered in the REBOUND actions are also passing

@hannorein
Copy link
Collaborator Author

Great! I think it depends on the compiler. const dotproduct = 3.3 was apparently interpreted as const int dotproduct = 3.3 (which is incorrect!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not install reboundx due to 'wheels error'
2 participants