Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes the issue in the notebook #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hannorein
Copy link
Collaborator

I don't know if this is the right solution!

@hannorein
Copy link
Collaborator Author

Note that REBOUNDx used to use dt_last_done for this effect. See e.g.

const double dt = sim->dt_last_done;

@hannorein
Copy link
Collaborator Author

Maybe this is obvious, but why does this effect not work at all (not change to orbital parameters) for integrators other than IAS15/WHfast? E.g. BS, SABA, leapfrog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant