Avoid tainting the default config #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests, depending on the order they are discovered, the default_config can become tainted before the test_default_config test is run. This causes this test to fail. Admittedly its likely never an issue when using ntfy as a script. But its in general a good practice not to direcly use mutable objects as default values and less flaky tests are easier to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests, depending on the order they are discovered, the default_config can become tainted before the test_default_config test is run. This causes this test to fail.
Admittedly its likely never an issue when using ntfy as a script. But its in general a good practice not to direcly use mutable objects as default values and less flaky tests are easier to handle.