Mimic Exif hierarchy in CRX #224
Conversation
| PushDirectory(new T()); | ||
| var directory = new T | ||
| { | ||
| Parent = Directories.OfType<TParent>().FirstOrDefault() |
There was a problem hiding this comment.
This is prone to selecting the wrong parent. The first one might not be the correct one. I would suggest adding the parent directory as a constructor parameter, storing it in a field, then adding it here.
You can then remove the TParent type parameter.
There was a problem hiding this comment.
You mean an additional directory stack in QucikTimeMetadataReader? I'm not sure if adding state to the latter is better than the current solution.
There was a problem hiding this comment.
Isn't SetTiffMarker only called once? I don't think a stack is needed.
There was a problem hiding this comment.
I meant the state would be in this class (QuickTimeTiffHandler).
There was a problem hiding this comment.
The reader encounters the atoms in order:
- CMT1
- CMT2
- CMT3
- CMT4
For each of those, a new ITiffHandler instance is created, meaning a directory stack created from scratch every time.
N.B. I don't see a scenario in which more than one IFD0 directory exists (at least at this stage).
There was a problem hiding this comment.
Thanks for clarifying. I still feel it should be possible to pass the parent forward somehow rather than looking it up, but will have to pull down your branch to play around with it.
No description provided.