bug(tiering): add prints to find crash flow #2673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theyueli lets try to run this branch, before you run memtier the second time we will set the vmodule flag to see the flow of the crash |
sounds good |
theyueli
previously approved these changes
Mar 4, 2024
src/server/tiered_storage.cc
Outdated
| @@ -480,6 +481,7 @@ bool TieredStorage::PrepareForOffload(DbIndex db_index, PrimeIterator it) { | |||
| } | |||
|
|
|||
| void TieredStorage::CancelOffload(DbIndex db_index, PrimeIterator it) { | |||
| VLOG(2) << "PrepareForOffload:" << it->first.ToString(); | |||
There was a problem hiding this comment.
typo: PrepareForCancelOffLoad
src/server/tiered_storage_test.cc
Outdated
| @@ -318,4 +319,23 @@ TEST_F(TieredStorageTest, GetValueValidation) { | |||
| EXPECT_EQ(m.db_stats[0].tiered_entries, 0); | |||
| } | |||
|
|
|||
| TEST_F(TieredStorageTest, CrashBug) { | |||
There was a problem hiding this comment.
thanks for providing such a template.
|
@adiholden @theyueli is something pending or shall we close this ? |
|
@kostasrim I will edit the unit tests for merge later. keep this open |
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
adiholden
force-pushed
the
catch_tiering_crash
branch
from
2ca1013
to
9db7299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.