Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG ERRORS #1703

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

DEBUG ERRORS #1703

wants to merge 9 commits into from

Conversation

talbii
Copy link
Contributor

@talbii talbii commented Aug 15, 2023

Closes #1531.

Logs errors in a Redis connection to an additional sink buffer, and returns them whenever DEBUG ERRORS is invoked. The sink buffer is stored within RedisReplyBuilder, and is given in the constructor. It is individual per ReplyBuilder, hence per connection.


very MVP for now, no need to review unless you see something critical :)

  • Log input string (the invoked command, CID) as well
    • $\star$ Log full input string (CID + arguments)
  • Replace StringSink with a RingBufferSink RingBuffer<std::string>
  • Tidy up

@talbii talbii marked this pull request as ready for review August 23, 2023 09:55
@talbii
Copy link
Contributor Author

talbii commented Sep 26, 2023

@romange Hey! What's the status of this PR? When I left it was ready for review. Happy to do any corrections as needed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easily identify commands triggering error responses
1 participant