Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Adding FilterMatch, Allow Multiple Columns Ordering, Fixes Filter front_end #1983 #1986

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gbrault
Copy link

@gbrault gbrault commented Jan 27, 2023

Description

ADDITIONAL INFORMATION

Fixes #1983

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new features
  • Removes existing feature

e.val is transformed into e.delegateTarget.value as the underlying html element is a select2 now
SqlAlchemy allow Match filter which is usefull when the underlying model is based upon a FTS (full text search) table
Enable multiple column ordering using a tuple instead of a string in the order parameter in the view definition
@gbrault gbrault changed the title Adding FilterMatch, Allow Multiple Columns Ordering, Fixes Filter front_end #1983 refactor Adding FilterMatch, Allow Multiple Columns Ordering, Fixes Filter front_end #1983 Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1986 (7680054) into master (dcb32c7) will decrease coverage by 33.31%.
The diff coverage is 15.78%.

❗ Current head 7680054 differs from pull request most recent head 8ce1e81. Consider uploading reports for the commit 8ce1e81 to get more accurate results

@@             Coverage Diff             @@
##           master    #1986       +/-   ##
===========================================
- Coverage   78.13%   44.83%   -33.31%     
===========================================
  Files          71       71               
  Lines        8612     8501      -111     
===========================================
- Hits         6729     3811     -2918     
- Misses       1883     4690     +2807     
Flag Coverage Δ
python 44.83% <15.78%> (-33.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/sqla/interface.py 18.36% <0.00%> (-63.57%) ⬇️
flask_appbuilder/views.py 39.65% <25.00%> (-26.47%) ⬇️
flask_appbuilder/models/sqla/filters.py 45.08% <66.66%> (-36.36%) ⬇️
flask_appbuilder/security/sqla/apis/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flask_appbuilder/security/sqla/apis/role/schema.py 0.00% <0.00%> (-100.00%) ⬇️
flask_appbuilder/security/sqla/apis/user/schema.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/role/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/user/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/view_menu/api.py 0.00% <0.00%> (-100.00%) ⬇️
...sk_appbuilder/security/sqla/apis/permission/api.py 0.00% <0.00%> (-100.00%) ⬇️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gbrault
Copy link
Author

gbrault commented Jan 27, 2023

I just used a clean appbuilder coming from your site and injected couple of changes that were not included and the automated workflow rejects almost everything: something must be wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrading to flask-appbuilder 4.2.0 from 4.1.6 search filter greater than or less than does not work
1 participant