sg_turs: do not report error for standby or unavailable ports #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LUN might be in ALUA 'standby' or 'unavailable', but this is perfectly okay and does not indicate that the device is not ready (in the sense that a repeated call to 'sg_turs' might report different states). So do not report an error for these devices. Signed-off-by: Hannes Reinecke <[email protected]>
|
Thanks. Applied upstream with some documentation additions. Mirrored here and corresponds to my svn revision number 980. Does rescan-scsi-bus.sh need any changes to use these new exit status categories? |
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch from @hreinecke fixes a problem where
rescan-scsi-bus.shwas extremely slow because of repeated probing of standby devices intestonline. Our customer the slowness only in older releases of sg3_utils (1.43), but it should also be helpful for more recent releases.