Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sg_vpd_vendor: Fix missing newline in the svpd_decode_vendor() error path #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tbzatek
Copy link

@tbzatek tbzatek commented Jun 8, 2022

This fixes the output of sg_vpd trying to fetch VPD pages and reporting failure:

...
SCSI Ports VPD page:
  Relative port=1
    Target port descriptor(s):
      designator type: NAA,  code set: Binary
       transport: Serial Attached SCSI Protocol (SPL-4)
        0x3222222000003e7e
  Relative port=2
    Target port descriptor(s):
      designator type: NAA,  code set: Binary
       transport: Serial Attached SCSI Protocol (SPL-4)
        0x3222222000003e7f

Vendor VPD page=0xc0  failed to fetchVendor VPD page=0xc1  failed to fetchVendor VPD page=0xc2  failed to fetchVendor VPD page=0xc3  failed to fetchVendor VPD page=0xc4  failed to fetchVendor VPD page=0xc5  failed to fetchVendor VPD page=0xc8  failed to fetchVendor VPD page=0xc9  failed to fetchVendor VPD page=0xca  failed to fetchVendor VPD page=0xd0  failed to fetchVendor VPD page=0xd1  failed to fetchVendor VPD page=0xd2  failed to fetch[root@localhost ~]# 

@doug-gilbert
Copy link
Owner

Applied upstream. Will appear when the next subversion revision is pushed to this github mirror.
Thanks.
BTW Starting to add JSON support. Starting small, so far with sg_opcodes and sg_rep_zones. Try the --json[=JO] option.

@tbzatek
Copy link
Author

tbzatek commented Jun 9, 2022

Oh nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants