[WIP] Add command support #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnycase
reviewed
Aug 27, 2017
| /// 判断是否具有特定的权限 | ||
| /// </summary> | ||
| /// <param name="permission">要判断的权限</param> | ||
| bool HasPermission(Permission permission); |
There was a problem hiding this comment.
Methods in a grain's interface must return Task or Task<T>.
sunnycase
reviewed
Aug 29, 2017
| /// <returns>命令名及命令的参数</returns> | ||
| /// <exception cref="ArgumentException"><paramref name="input"/> 不合法</exception> | ||
| public static (string, IList<ICommandArgument>) ParseCommand(string input) |
There was a problem hiding this comment.
Use IReadOnlyList<> instead.
akemimadoka
force-pushed
the
Command
branch
3 times, most recently
from
cfaaad2
to
7ba763c
Compare
akemimadoka
force-pushed
the
Command
branch
from
7ba763c
to
748b8cf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working for #26