Bug dotnet/sdk-container-builds#559: PublishContainer Appends "dotnet <Target>.dll" to ENTRYPOINT for Self Contained Builds #40792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Containers
erikbra
force-pushed
the
bugs/559-publishcontainer-appends-dotnet
branch
from
3647099
to
54f65fc
Compare
baronfel
approved these changes
May 9, 2024
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
baronfel
reviewed
May 9, 2024
test/Microsoft.NET.Build.Containers.IntegrationTests/TargetsTests.cs
Outdated
Show resolved
Hide resolved
erikbra
force-pushed
the
bugs/559-publishcontainer-appends-dotnet
branch
from
7b67edd
to
d6193fb
Compare
erikbra
changed the title
…RYPOINT for Self Contained Builds * Fixed existing integration test that tested that ContainerEntryPoint can be deferred (it wasn't actually testing anything, due to a bug in the test) * Changed the test to test that we defer ContainerAppCommand instead (ContainerEntryPoint is not deferred anymore on .net 8) * Added runtime identifier dimension to the test (linux vs windows) * Fixed integration test ProjectInitializer to take into account Windows vs *nix when setting executable extension (.exe or nothing) * Fixed Microsoft.NET.Build.Containers.targets so that the behaviour is as expected on both Windows and linux containers
…ter align with e.g. OutputPath
erikbra
force-pushed
the
bugs/559-publishcontainer-appends-dotnet
branch
from
d6193fb
to
151ef05
Compare
|
@tmds if you have a moment I'd love to get your eyes on this as well - I'm quite happy with the changes but you also have some history in this space. |
MichalPavlik
approved these changes
May 15, 2024
tmds
reviewed
May 15, 2024
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
baronfel
reviewed
May 15, 2024
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
|
Applied that fix and marked for merge. Thank you @erikbra for this contribution, and the related MSBuild issue writeup! |
|
Thanks for the follow-up, fix and merge, @baronfel ! I'm excited about which way the MsBuild issue/concern will go. I think that one's more deep-rooted in the core templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug dotnet/sdk-container-builds#559: PublishContainer Appends "dotnet .dll" to ENTRYPOINT for Self Contained Builds
Fixes dotnet/sdk-container-builds#559