Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the WinForms app test #40708

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented May 6, 2024

Enhance the WinForms test to run as well (it is only publishing currently) to cover the Issue 11282 uncovered. Likely will need to update the SDK global.json file to a more recent runtime version to get the recently merged PR 4366

@LakshanF LakshanF self-assigned this May 6, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels May 6, 2024
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to set a specific exit code so that you know that the app exited the way you were expecting.


protected override void OnShown(EventArgs e)
{
Close();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To exit with specific code I believe we change this to call Environment.Exit() with preferred exit code would work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%errorlevel% seems still to be 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants