Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.4xx] Update dependencies from dotnet/msbuild #40435

Merged
merged 27 commits into from
May 20, 2024
Merged

[release/8.0.4xx] Update dependencies from dotnet/msbuild #40435

merged 27 commits into from
May 20, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 25, 2024 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: d6b910b6-e0a7-4a37-57d4-08dc59608cf9
  • Build: 20240517.2
  • Date Produced: May 17, 2024 10:28:29 PM UTC
  • Commit: ffe4ef22354ca51185ca5b3557e1324ec40c8d81
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
5f8e0e7 
…0425.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24225-02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Apr 25, 2024
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
00b8895 
…0425.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24225-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
55b13a9 
…0426.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24226-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
66179eb 
…0428.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24228-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
7edabfd 
…0429.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24229-01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
011e68c 
…0430.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24230-01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
624f7cc 
…0430.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24230-06
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
85227f8 
…0502.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24252-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
431b7bb 
…0502.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24252-03
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
77bd981 
…0504.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24254-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
100fdce 
…0504.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24254-02
@v-wuzhai
Copy link
Member

v-wuzhai commented May 6, 2024

@dotnet/kitten These failures seem to be the same as PR #40433.

dotnet-maestro bot and others added 2 commits May 6, 2024 12:46
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
2a217f9 
…0506.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24256-01
@maridematte
Allow parameters to be null
de88fd8
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 7, 2024 12:16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
c2ea64c 
…0507.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24257-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
1810b9e 
…0507.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24257-06
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
b905f59 
…0509.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24259-07
@marcpopMSFT
Copy link
Member

ping @dotnet/kitten

@Forgind
Copy link
Member

Forgind commented May 10, 2024

Microsoft.Build.Exceptions.InvalidProjectFileException: Invalid static method invocation syntax: "[MSBuild]::SubstringByAsciiChars($(MSBuildProjectFile), 0, 8)". Method '[MSBuild]::SubstringByAsciiChars' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(a, b)). Check that all parameters are defined, are of the correct type, and are specified in the right order. C:\h\w\AEA3094D\p\d\sdk\8.0.400-ci\Microsoft.Common.CurrentVersion.targets

I think this is the relevant error. It seems like that's a new function added as part of this change. Still poking at it a bit.

@rainersigwald
Copy link
Member

Merge and then backport #40603 please :)

@Forgind
Copy link
Member

Forgind commented May 10, 2024

Merge and then backport #40603 please :)

Are you suggesting merge + backport instead of retargeting to 8.0.4xx then letting it flow because its current version is approved and is passing tests? If it weren't ready to go in, I'd be inclined to retarget, but this is close enough that I think that makes sense.

That PR looks like it would resolve the symptoms I was seeing (picking up old engine instead of most up-to-date version) 👍

I think kasperk81 is correct that checking just TargetFrameworkIdentifier is sufficient, but that's just a tiny nit.

It looks like it got stuck behind some build legs that didn't check status properly, which means I don't have the power to merge. @marcpopMSFT, can you help?

@rainersigwald
Copy link
Member

I have no objection to rebasing + retargeting that PR, that's up to y'all.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
ddb0b74 
…0509.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24259-07
@build-analysis build-analysis bot mentioned this pull request May 11, 2024
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
f0d3ed2 
…0509.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24259-07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
c7e427f 
…0509.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24259-07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
05610ff 
…0513.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24263-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
85561ba 
…0513.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24263-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
41576e9 
…0513.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24263-02
@dsplaisted
Copy link
Member

#40883 is the backport PR that should fix this

dotnet-maestro bot and others added 5 commits May 17, 2024 13:25
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
046d57e 
…0516.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24266-03
@maridematte
Revert "Allow parameters to be null"
b1d9704 
This reverts commit de88fd8.
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
58d8afc 
…0517.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24267-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
1173273 
…0517.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24223-07 -> To Version 17.11.0-preview-24267-02
@nagilson
Update msbuild minimum dependency to latest msbuild
04a91e1 
Merge remote-tracking branch 'upstream/release/8.0.4xx' into darc-release/8.0.4xx-b52e5e7c-435f-44a6-aa3a-dc561cbce985
@nagilson nagilson enabled auto-merge May 20, 2024 18:46
@nagilson nagilson merged commit 1e2e681 into release/8.0.4xx May 20, 2024
20 of 21 checks passed
@nagilson nagilson deleted the darc-release/8.0.4xx-b52e5e7c-435f-44a6-aa3a-dc561cbce985 branch May 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@v-wuzhai @marcpopMSFT @Forgind @rainersigwald @dsplaisted @nagilson @maridematte