feat: Add support for updatedTypes in metadata updates #40416
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-AspNetCore
|
Thanks for your PR, @jeromelaban. |
4 tasks
|
Note, I'm not sure how to test this properly on the CI's side, considering it requires an integration from the Blazor as well. Thanks for the reviews! |
There was a problem hiding this comment.
Thanks for the contribution, @jeromelaban!
We may also need to update this struct to have an UpdatedTypes property and update these tests to verify it.
jeromelaban
force-pushed
the
dev/jela/updatedtypes-hr
branch
from
082183a
to
ad90515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related dotnet/aspnetcore#52937, corresponding PR in blazor: dotnet/aspnetcore#55347
This PR passes the updatedType parameter in order by the hot reload agent to properly invoke MetadatatUpdateHandler types.