JIT: Canonicalize entry BB early #102280
Merged
JIT: Canonicalize entry BB early #102280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canonicalize entry BB before the early transformations instead of doing it as part of the transformations. This allows us to move the morph DFS even earlier, which will be useful for other phases as well.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib PTAL @EgorBo superpmi-diffs failure looks like an infra issue. |
EgorBo
approved these changes
May 16, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Canonicalize entry BB before the early transformations instead of doing it as part of the transformations. This allows us to move the morph DFS even earlier, which will be useful for other phases as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonicalize entry BB before the early transformations instead of doing it as part of the transformations. This allows us to move the morph DFS even earlier, which will be useful for other phases as well.
This is a prerequisite for the fix to #87072 and #102273; I expect to use an RPO traversal during local morph to do early propagation of
LCL_ADDRnodes. This change makes the RPO available during local morph.