Bump major version to 9 #10320
Merged
Bump major version to 9 #10320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjonescz
commented
Apr 26, 2024
•
jjonescz
commented
- Follow up on Unrevert "Bump version to 8" #9303.
- Needs a new binding redirect in VS: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/546969
- It's needed to make WebTools find the Razor DLL even if it has a different major version than they reference. Without that change, WebTools has NGEN errors (cannot find the DLL v7).
- This needs to be done only once, then future insertions should work even when major version changes again.
- Official build run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442972
- VS insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/548337 (fails with NGEN error)
- VS insertion + binding redirect: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/548340 (succeeds)
- New VS insertion after with the binding redirect PR already merged into VS main: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/551888
333fred
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM, assuming that binding redirect internal PR is good. It looks like RPS failed? https://dev.azure.com/devdiv/DevDiv/_git/VS/pullRequest/546969#1714134562
Just 1 iteration out of 6. I think that's fine (flaky thing). But will re-run the RPS to be sure. However, it looks like I need some specific approvals to be able to merge that VS PR, I'm not sure where to get those. |
|
The VS side PR is merged. I will run another validation insertion and merge this once it looks like Razor insertions are stable. @chsienki if you want to take a look before I merge this |
chsienki
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.