-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the shipping version of MSBuild #19041
base: release/8.0.1xx
Are you sure you want to change the base?
Conversation
marcpopMSFT
commented
Mar 13, 2024
- Please add description for changes you are making.
- If there is an issue related to this PR, please add the reference.
@MichaelSimons as you predicted, this change didn't impact the older branches but did affect SB in 8+. What's the fix here? Just add the new msbuild bits to the exclusion list? I tried to match the version we're shipping so not sure why an exclusion would be needed for SB. |
The corresponding version.details.xml entry needs to be marked as source-build. Add - |
@MichaelSimons adding the line and your update didn't fix the leg either. Any ideas? We'll also need to fix #19017 after |
My change did fix the original issue in that the intermediate could not be found. Now there are prebuilts reported. /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : 4 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. |
Those packages will need to be added to https://github.com/dotnet/source-build-reference-packages. |
@MichaelSimons coming back to this. Is this what I was supposed to do? I wasn't sure what order to add things into the eng/build.props file (and was a bit confused by that file being empty). Running the generate command included a bunch of other edited files but I excluded those from my commit. |